display options

https://thread.zone/account/display

only a few settings rn but i’ll add more

added a “display images as links” thing to this

added a Open Links in New Tab option

also let me know if this breaks anything i had to fuck with a lot of the ‘core’ parts of the site

damn, thanks tiko

update: new tab for links doesn’t work in chrome in windows 10

update 2: or firefox. however, my husband reports that it was working on his phone’s firefox

but for whatever reason it’s not working for me

update 3: tested it on firefox on my android phone as well, nothing
also tried clearing cache, doesn’t help

From: Tiko at 2017-12-26 19:59:18
added a “display images as links” thing to this

thnx

getting reports from other friends that it works fine for them as well. i wonder what the issue could be that it’s not working on my phone OR the random computer i’m on atm in any browser

it might be something account-specific. though i already checked and it automatically updated the option to the new setting on my phone’s logged in session when i changed it on the desktop session so it’s not a matter of like a stray logged-in session somewhere holding it up, i wouldn’t think

i tried unchecking the option and saving, then changing it back to the new behavior, saving again, clearing cache again, still doesn’t work

i also tried disabling ublock origin for that page just in case, with no change in results
though the copy of firefox i installed to check the behavior had no extensions, so that’s probably not it

phone testing update: i tried force stopping firefox and clearing its cache manually, then logging back in, confirming the setting was set correctly… still no result. weird.

there’s gotta just be like a stuck flag in the database for my account or something, i’m logged into at least 3 locations so maybe that’s messing with it

also incognito mode / private browsing doesn’t seem to change anything vs. a regular browser window

i’m not sure what i’m doing so if there’s any log outputs or anything that would help i’m happy to provide them

works on chrome osx
safari ios
works on windows firefox
works on windows chrome for me too

hmm strange ill try some stuff
one thing that could fuck it up is if you idle in one thread for a long time, the live messages will follow whatever your format choices were when you loaded the topic. but reloading should fix it 🤔

anyway try this:
turn the option on
right click a link and inspect element
in the HTML does the <a> tag have a target="_blank" attribute?
if it does and still opens in the same window, it might be an errant popup blocker or something

i would have to guess maybe a weird tab manager? she’s having the same problem on mobile and desktop with the same browser that shares extensions but i thought she tried disabling her adblocker

i looked at her account settings in the DB and the display options seem to be saved fine
hmm

From: Tiko at 2017-12-27 04:33:10
anyway try this:
turn the option on
right click a link and inspect element
in the HTML does the <a> tag have a target="_blank" attribute?
if it does and still opens in the same window, it might be an errant popup blocker or something

sorry, just saw this post
lemme try

hm, no it looks like <a href=“thelink.com” rel=“nofollow”>

also i’m at home now and it’s not working on my home computer either lol
windows 7 and firefox

just to check, i tried disabling firefox’s automatic popup blocking. no dice

seems like your setting isnt working and its my fault… i will investigate

OK i think i fixed it
the root of the bug was very stupid and it boils down to if your timezone was the default your settings wouldn’t apply properly

From: Tiko at 2017-12-27 07:29:21
OK i think i fixed it
the root of the bug was very stupid and it boils down to if your timezone was the default your settings wouldn’t apply properly

!

lol ok lemme check

hooray it works, thanks tiko :)

best bird

yay

what was the deal with the bug, anyway, you’ve got me curious

or is that all there was to it

probably none of the settings were changing if you were on the default timezone cause it wasnt referencing your database entry for options just using the defaults

From: imgay at 2017-12-27 08:56:13
probably none of the settings were changing if you were on the default timezone cause it wasnt referencing your database entry for options just using the defaults

basically this. before the only thing that could change was dates and i put the new stuff inside the “is the timezone non default?” check accidentally lolz

also that png got really weirdly resized hmm

oh yeah pngs with transparent pixels get super fucked up on ul

ok i think i fixed that
i’m gonna add a thumbnail thing maybe. but images are already thumbed at a high-ish cutoff. so it’d just squish images more

lmk any ideas for display options i can add stuff more easily now

i really liked that dumb eti avatar crush on all imgs
where everything became static 150x150 imgs
it gives you enough info to not have to click a link when scrolling a long thread if you recognize the thumb or see its a photo or a landscape or whatever

i get it if its dumb to implement

nah i think i’ll add it. but it’ll only really work for newly uploaded images whenever it gets implemented

From: Tiko at 2017-12-27 09:52:34

From: imgay at 2017-12-27 08:56:13
probably none of the settings were changing if you were on the default timezone cause it wasnt referencing your database entry for options just using the defaults

basically this. before the only thing that could change was dates and i put the new stuff inside the “is the timezone non default?” check accidentally lolz

lol welp

From: Tiko at 2017-12-27 14:30:32
nah i think i’ll add it. but it’ll only really work for newly uploaded images whenever it gets implemented

that’s fine

something i’d like to see in the site display options for imgs is

full size
thumbnail
links only

thumbs in particular would make it easier to browse from a phone or look through filtered posts, provided they’re new, smaller imgs and not just the existing img dynamically resized through html fuckery

oh man this makes mobile browsing so much better thank u