Cannot generate valid invite with "Limit uses" set

I started a new, invite-only zone. I created a new invite with these settings:

Here is the result of pressing create:

Another user, not registered to the zone, copies and pastes the invite link and tries to join:

They are denied access because the invite code is invalid:

Here’s what I see in the invite status list:

This has happened for about five invite in a row. Am I using this wrong?

The invite works if I turn off the “limit uses” field. Is this some sort of weird browser pre-fetch behavior?

I first saw this on iOS Safari, but I’m also seeing it on Firefox 78.11.0esr

Setting the “Limit uses” box and putting any value in the number of uses creates an invalid invite.

Creating a time-limited invite works correctly.

Creating an invite not bound by use or time also works correctly.

MasterOfMagic changed the thread title from Cannot generate valid invite to Cannot generate valid invite with "Limit uses" set.

whoops i messed it up at some point. should be fixed and the invites working now

diff --git a/zone/invite.go b/zone/invite.go
index 2c5c85c..3c1355d 100644
--- a/zone/invite.go
+++ b/zone/invite.go
@@ -50,7 +50,7 @@ func (inv Invite) Remaining() int {
        if inv.Max == 0 && inv.Uses == 0 {
                return 1 // backwards compat
        }
-       if inv.Max >= inv.Uses {
+       if inv.Max < inv.Uses {
                return 0
        }
        return inv.Max - inv.Uses

this is why u dont name ur variables ambiguous stuff like Uses

lmbo

From: Tiko at 2021-06-15 05:47:32

diff --git a/zone/invite.go b/zone/invite.go
index 2c5c85c..3c1355d 100644
--- a/zone/invite.go
+++ b/zone/invite.go
@@ -50,7 +50,7 @@ func (inv Invite) Remaining() int {
        if inv.Max == 0 && inv.Uses == 0 {
                return 1 // backwards compat
        }
-       if inv.Max >= inv.Uses {
+       if inv.Max < inv.Uses {
                return 0
        }
        return inv.Max - inv.Uses

this is why u dont name ur variables ambiguous stuff like Uses

oh shit, i didn’t know the backend was written in go. lmk if you ever want backend help.

From: cosban at 2021-06-15 16:45:58
lmk if you ever want backend help.

Smirking face emoji

i know what i said

From: cosban at 2021-06-15 16:45:58

From: Tiko at 2021-06-15 05:47:32

diff --git a/zone/invite.go b/zone/invite.go
index 2c5c85c..3c1355d 100644
--- a/zone/invite.go
+++ b/zone/invite.go
@@ -50,7 +50,7 @@ func (inv Invite) Remaining() int {
        if inv.Max == 0 && inv.Uses == 0 {
                return 1 // backwards compat
        }
-       if inv.Max >= inv.Uses {
+       if inv.Max < inv.Uses {
                return 0
        }
        return inv.Max - inv.Uses

this is why u dont name ur variables ambiguous stuff like Uses

oh shit, i didn’t know the backend was written in go. lmk if you ever want backend help.

hey